Skip to content

lifi: include Jumper volume (remove integrator exclusion) - #8972

Open
Octave-byte wants to merge 1 commit into
DefiLlama:masterfrom
Octave-byte:lifi-include-jumper-clean
Open

lifi: include Jumper volume (remove integrator exclusion)#8972
Octave-byte wants to merge 1 commit into
DefiLlama:masterfrom
Octave-byte:lifi-include-jumper-clean

Conversation

@Octave-byte

Copy link
Copy Markdown
Contributor

The LI.FI bridge (bridge-aggregators/lifi) and swap (aggregators/lifi) adapters currently exclude the Jumper integrators (jumper.exchange, transferto.xyz, jumper.exchange.gas, lifi-gasless-jumper). This removes that exclusion on both the on-chain and analytics-API paths, so the LI.FI adapters report total LI.FI volume including Jumper.

The separate jumper.exchange / jumper-exchange adapters are intentionally left unchanged, so Jumper is still reported on its own.

The LI.FI bridge and swap adapters no longer exclude the Jumper
integrators (jumper.exchange, transferto.xyz, jumper.exchange.gas,
lifi-gasless-jumper), so they report total LI.FI volume including Jumper
on both the on-chain and analytics-API paths.

The separate jumper.exchange / jumper-exchange adapters are intentionally
left in place so Jumper is still reported on its own.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 35bc96fd-8f22-4c14-baa6-d314ee20335d

📥 Commits

Reviewing files that changed from the base of the PR and between e629a69 and 9a9e109.

📒 Files selected for processing (2)
  • aggregators/lifi/index.ts
  • bridge-aggregators/lifi/index.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Summary by CodeRabbit

  • Bug Fixes
    • LiFi volume reporting now includes activity from all integrators, including Jumper.
    • Bitcoin and Solana API-based volume totals now reflect complete integrator activity.
    • On-chain bridge and swap volumes now include all eligible events without integrator-based exclusions.

Walkthrough

LiFi volume aggregation now counts all integrators, including Jumper, across Bitcoin and Solana API results and qualifying on-chain swap or bridge events.

Changes

LiFi integrator volume

Layer / File(s) Summary
Count all integrator volume
aggregators/lifi/index.ts, bridge-aggregators/lifi/index.ts
The API aggregation paths no longer pass excluded integrators. On-chain aggregation paths now add qualifying events without checking the integrator.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 9a9e1

This localized change updates LI.FI volume reporting to include Jumper integrations, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested labels: aggregators, bug-fix

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the LI.FI change but does not follow the required "[type] protocol-name - description" format. Rewrite the title in the required format, such as "[fix] lifi - include Jumper volume by removing integrator exclusion".
✅ Passed checks (14 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the affected adapters, removed exclusions, reporting behavior, and unchanged Jumper adapters.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Breakdown Methodology Check ✅ Passed The PR changes only volume adapters: both return dailyVolume/dailyBridgeVolume and contain no dailyFees or breakdown labels, so the fees-adapter check is inapplicable.
Income Statement Compliance ✅ Passed PR changes only FetchResultVolume fields (dailyVolume/dailyBridgeVolume). The unchanged fees/lifi adapter sets dailyFees = dailyRevenue + dailySupplySideRevenue.
Version 2 Required ✅ Passed Both changed LI.FI adapters export version: 2, and the PR diff leaves those declarations unchanged while removing only integrator exclusions.
Pullhourly Required For Version 2 ✅ Passed Both changed LI.FI adapters declare version: 2 and explicitly set pullHourly: true at lines 45-46 and 33-34.
Dune Adapters Are Version 1 ✅ Passed Both changed adapters use fetchVolumeFromLIFIAPI, which calls li.quest via fetchURL; no queryDune, queryDuneSql, Dune helper, or TIME_RANGE usage exists in the PR paths.
Income Statement Balance ✅ Passed The diff changes only LI.FI volume fields (dailyVolume and dailyBridgeVolume). It adds no dailyFees or revenue fields, so the fees balance check is not applicable.
Fetchoptions Usage ✅ Passed Both changed adapters use (options: FetchOptions), use options.startTimestamp/endTimestamp, return only volume fields, and retain version 2 hourly configuration; the diff changes only integrator fi...
Adapter Shape ✅ Passed The PR changes only integrator filtering. Both adapter declarations are unchanged from the parent, and LifiDiamonds has distinct per-chain starts, so the per-chain adapter shape remains justified.
Efficiency And Error Handling ✅ Passed Parent/current diffs show only integrator-filter removal and comments; getLogs, eventAbi, topic hash, loops, catches, rates, and allowNegativeValue were unchanged or absent.
Methodology Keys ✅ Passed The PR changes only LI.FI integrator filtering; the diff and AST searches show no methodology object or methodology keys in either changed file.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch lifi-include-jumper-clean
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bheluga bheluga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Octave-byte thanks for the PR
We count those volumes in jumper aggregator and bridge aggregator (https://defillama.com/protocol/jumper-(li.fi-powered)).
So that would be double counted right?

@bheluga bheluga self-assigned this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants